alphacsc icon indicating copy to clipboard operation
alphacsc copied to clipboard

ENH add data loader for camcan dataset + add event description into info

Open CedricAllain opened this issue 3 years ago • 3 comments

  1. alphacsc/datasets/camcan.py: new file, add a data loader function with default pre-processing parameters
  2. alphacsc/datasets/mne_data.py: add an event description dictionary in info['event_info']

CedricAllain avatar Oct 26 '22 09:10 CedricAllain

We need to discuss where to put this code as alphacsc is probably not a great fit

Indeed, maybe it is not really appropriate. I did this as there is a data loader of HCP in datasets/hcp.py.

CedricAllain avatar Oct 28 '22 09:10 CedricAllain

Codecov Report

Merging #102 (16592c5) into master (1e8cf32) will increase coverage by 0.05%. The diff coverage is n/a.

:exclamation: Current head 16592c5 differs from pull request most recent head e6ebbd0. Consider uploading reports for the commit e6ebbd0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
+ Coverage   82.09%   82.14%   +0.05%     
==========================================
  Files          22       22              
  Lines        2166     2172       +6     
==========================================
+ Hits         1778     1784       +6     
  Misses        388      388              

codecov-commenter avatar Oct 28 '22 13:10 codecov-commenter

to me the hcp loader should not be present here or at least not using hard coded path. There is no chance this hcp code is working for anyone.

agramfort avatar Oct 29 '22 17:10 agramfort