Alpha icon indicating copy to clipboard operation
Alpha copied to clipboard

Code smell in DefaultSolver#fixContradiction

Open rtaupe opened this issue 4 years ago • 3 comments

DefaultSolver#fixContradiction returns conflictAnalysisResult.learnedNoGood, which, however, must always be null. The caller, DefaultSolver#ingest, then checks if the returned value is not null (which can never be the case). Something is not right here!

rtaupe avatar May 06 '20 08:05 rtaupe