git-annex-adapter icon indicating copy to clipboard operation
git-annex-adapter copied to clipboard

Incompatibility with distro versions of git-annex

Open alpernebbi opened this issue 8 years ago • 12 comments

Currently, git-annex 6.20160727 (or later) is supported, but this isn't in most of the distro repositories:

The adapter should be made compatible with these versions until they are upgraded by the maintainers.

A short list of things that I rely on and aren't available in these versions:

  • [ ] metadata --batch --json (6.20160727)
  • [ ] Metadata fields being enclosed in a fields object in JSON output. (6.20160726)

alpernebbi avatar Dec 08 '16 18:12 alpernebbi

For what it's worth, I think it is reasonable for you to not support older versions.

I have emailed the Arch maintainer about updating the package. I'll post here if that happens.

pigmonkey avatar Dec 08 '16 18:12 pigmonkey

There seem to be several packages in the AUR for git-annex but they appear to be more outdated.

For what it's worth, I think it is reasonable for you to not support older versions.

I can do that if the version is updated in the Arch repo (and if I don't encounter anyone who uses this with Fedora), since Ubuntu and Debian can install it from NeuroDebian. I had already written code for managing metadata without using the batch mode, so it shouldn't be impossible to put that back in as a fall-back. It would take some time though.

Thanks for contacting the maintainer.

alpernebbi avatar Dec 08 '16 19:12 alpernebbi

The upgrade of git-annex is blocked due to build failure of AWS library with the latest http-conduit. It's been fixed only recently and new release isn't available yet. Once it's out, @felixonmars will surely upgrade it.

barthalion avatar Dec 09 '16 10:12 barthalion

I have updated aws some days ago, but git-annex itself is still blocked by new http-conduit: https://git-annex.branchable.com/bugs/Build_with_aws_head_fails/

felixonmars avatar Dec 09 '16 11:12 felixonmars

Thanks for the clarification! Hopefully @joeyh can provide some insight on that bug.

pigmonkey avatar Dec 10 '16 01:12 pigmonkey

I posted a patch on that page, which I believe fixes the problem. I can build it successfully, git-annex test reports all tests passed, but it's my first attempt at Haskell so it might be doing something wrong.

Here is the modified package: git-annex-6.20161118-8-x86_64.pkg.tar.xz.zip. I had to zip it since GitHub apparently doesn't like tar.xz.

alpernebbi avatar Dec 10 '16 13:12 alpernebbi

Alper Nebi Yasak wrote:

I posted a patch on that page, which I believe fixes the problem. I can build it successfully, git-annex test reports all tests passed, but it's my first attempt at Haskell so it might be doing something wrong.

The patch looks reasonable, unfortunately, git am fails to apply it. Could you please post a working patch, or a git repo I can merge from?

-- see shy jo

joeyh avatar Dec 10 '16 14:12 joeyh

Oh, I see, some mangling of " in the patch. Got it to apply cleanly.

joeyh avatar Dec 10 '16 14:12 joeyh

I have to apologise for changing the metadata --json format. There were good reasons to do so.

Most non-frozen linux distros are keeping reasonably current, so I hope that the current metadata --json --batch will be available in them soon. I wonder what is keeping Fedora on such an ancient version. Pinged the Fedora maintainer.

joeyh avatar Dec 10 '16 14:12 joeyh

Thanks a lot for the patch. The Arch package has been updated to 6.20161118 with this patch: https://www.archlinux.org/packages/community/x86_64/git-annex/

felixonmars avatar Dec 10 '16 16:12 felixonmars

I have to apologise for changing the metadata --json format. There were good reasons to do so.

I think that's a good change! (Although I'm still guilty in making file and key correspond to the file path and git-annex key instead of actual fields.)

I wonder what is keeping Fedora on such an ancient version. Pinged the Fedora maintainer.

Thanks! I've also found Bug 1176888 - git-annex-6.20161118 is available which has been automatically complaining for a long time.

Thanks a lot for the patch. The Arch package has been updated to 6.20161118 with this patch:

Looks like @joeyh released git-annex 6.20161210 with my patch in it as well. I hope that doesn't cause a conflict.

alpernebbi avatar Dec 10 '16 18:12 alpernebbi

Don't worry :)

felixonmars avatar Dec 11 '16 01:12 felixonmars