alpaka icon indicating copy to clipboard operation
alpaka copied to clipboard

[RFC] Mark CATCH cmake variables as advanced

Open bernhardmgruber opened this issue 2 years ago • 2 comments

I just noticed that we got a lot of cmake variables from Catch2 in the default view of ccmake: image

Since I don't think that we should tamper with these variables, I would like to mark them as advanced in cmake, so they are hidden by default.

bernhardmgruber avatar Jun 30 '22 11:06 bernhardmgruber

I don't think this is the right approach. We should probably use ExternalProject(https://cmake.org/cmake/help/v3.18/module/ExternalProject.html) instead.

j-stephan avatar Jul 06 '22 11:07 j-stephan

If that gets rid of the CATCH_* cmake variables, I am all for it!

bernhardmgruber avatar Jul 06 '22 12:07 bernhardmgruber

@j-stephan are you going to do the thing with ExternalProject? If not, are you fine with my suggested approach? If not, then I would close the issue.

bernhardmgruber avatar Dec 09 '22 13:12 bernhardmgruber

Not right now, but I'm still for trying out ExternalProject. Shouldn't be that hard I think.

j-stephan avatar Dec 09 '22 13:12 j-stephan

Ok then, go for it! :)

bernhardmgruber avatar Dec 09 '22 13:12 bernhardmgruber

I just tried it with FetchContent which should be really similar to ExternalProject. The variables still show up in ccmake so feel free to try out your approach.

j-stephan avatar Dec 09 '22 13:12 j-stephan