django-modern-rpc icon indicating copy to clipboard operation
django-modern-rpc copied to clipboard

Published 20 hours ago • verified publisher icon alorence

RFC: rate limit support

Open atodorov opened this issue 2 years ago • 1 comments

I had the impression that this library supported rate limiting but I can't find anything on that topic. Maybe I am wrong.

In any case has anyone tried other rate-limiting libraries in conjunction with django-modern-rpc?

If not what do people think about adding such support? Any hints to implementation? I can work on a PR sometime in the future as I will probably need such functionality.

atodorov avatar Feb 25 '22 21:02 atodorov

Hi Alexander,

No this was never implemented in the lib, but I think it's a good ideai to think about a way to integrate such a feature. I don't know if it is interesting to reinvent the wheel and write a new way to throttle incoming requests. Some lbraries already exists: https://djangopackages.org/grids/g/antiflood/

Did you already look at some of them ? Maybe we could try to see which one can be used with django-modern-rpc, and ensure it can be integrated corectly. Technically, I think it could be implemented with the help of authentication features. But it is not ideal. Maybe django-modern-rpc may be updated to allow a more generic concept of pre-request check, encapsulating throttling, authentication, and maybe other kind of checks.

The first alpha of the incoming 1.0.0 release was published yesteray. We could work on this for a future 1.1 or 1.2 ? What do you think ?

alorence avatar Mar 04 '22 21:03 alorence