parquet-dotnet icon indicating copy to clipboard operation
parquet-dotnet copied to clipboard

Published 20 hours ago • verified publisher icon aloneguid

Fix issue #168 optionals without stats

Open Teun opened this issue 2 years ago • 3 comments

Fixes

Issue #168 and maybe also issue #164

Description

  • [x] I have included unit tests validating this fix.
  • [x] I have updated markdown documentation where required.
  • [x] I understand that successful approval of my pull request requires reproducible tests as per Contribution Guideline.

Teun avatar Jun 13 '22 16:06 Teun

Added a unit test proving that #164 is also fixed with this PR

Teun avatar Jun 13 '22 16:06 Teun

Thank you

jbautistam avatar Jun 16 '22 13:06 jbautistam

Mystery to me why that Á in the literal string caused issues. Looks fine in my branch, looks fine after the PR merge, but indeed, when I check out the code on a mac, it garbles the string. Have replaced it by a \u reference and now it works fine on the mac.

Teun avatar Aug 06 '22 15:08 Teun

@aloneguid could you please make he CI actions run again? The pushed changes should have fixed the MacOS problem.

Teun avatar Sep 07 '22 08:09 Teun

@Teun not sure how to trigger CI, it should just kick off automatically.

aloneguid avatar Sep 07 '22 10:09 aloneguid

@Teun is there any chance we could proceed with these changes?

kzrodlowski avatar Sep 14 '22 09:09 kzrodlowski

I'd love to, but I'm not sure about the process. I provided a PR, the Test action found a problem. Then I pushed a fix for that issue, but the action never ran again. Maybe someone with the required privileges can run it manually?

Teun avatar Sep 14 '22 14:09 Teun

I'd love to, but I'm not sure about the process. I provided a PR, the Test action found a problem. Then I pushed a fix for that issue, but the action never ran again. Maybe someone with the required privileges can run it manually?

@aloneguid could I ask you for help with driving this PR to completion? If there's no easy way to trigger it, should the PR be re-submitted?

kzrodlowski avatar Sep 19 '22 11:09 kzrodlowski

I can't figure out how to force this, so merging and will deal with errors in master if any. Expect a release shortly.

aloneguid avatar Sep 20 '22 14:09 aloneguid

Does this fix exist in the latest version (4.23.x)? I'm trying to update from 3.10.x to the latest and seeing failure around this. Can someone confirm?

shamimashik avatar Mar 14 '24 16:03 shamimashik