Alon Bar-Lev
Alon Bar-Lev
CI `windows port / build-vs (x64, Debug, dev, 2017)` failure is unrelated.
Hi @robert-hh, I would love to hear what you think. Thanks,
Helllo @robert-hh , Thank you for reviewing. > * Since it selects the `channel_sample_mode`, maybe call it as such, or shorter `channel_mode,` matching the NXP header file terminology. The data...
Hello @robert-hh , Reading your verbose response, do I understand correctly that you want to remove all the content of: ``` mp_printf(print, "ADC(%u, channel=%u, channel_group=%u)", i, self->channel, self->channel_group); ``` As...
Hi, I tried and failed to create a patch to add differential mode. Adding enum: ``` enum { ADC_MODE_SINGLE_ENDED = 0, ADC_MODE_DIFFRENCIAL_AB, ADC_MODE_DIFFRENCIAL_BA, }; ``` And keyword argument `mode=ADC_MODE_SINGLE_ENDED` to...
> Only for MIMXRT11x I would change the text from "channel_group" to "channel input" Done, I hope this what you meant. > In your PR you use the NXP library...
> Looks better now. Looks like I made a typo for print. Of course it should be channel_input in one word. Fixed. Thank you!
Hi @robert-hh, Is something missing to merge this? Thanks, Alon
Hi @robert-hh, I already rebased today. Thanks,
Hello @dpgeorge, Is there anything more I can do in order to prepare this patch for merge? Regards,