almond
almond copied to clipboard
almond-sh
Add support for rich display of Python objects in ScalaPy (rebased)
Check out this pull request on 
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
![review-notebook-app[bot] avatar](https://avatars.githubusercontent.com/in/15474?v=4 "Published by a pub.dev verified publisher"){kind=small}
I don't if that'll fix the issue seen in https://github.com/almond-sh/almond/pull/843…
cc @kiendang
Looks like the error was caught by JNA somehow not being able to load libpython. I did check and libpython was there, handled correctly by python-native-libs. I used papermill to tee notebook cell outputs to stdout (can't do that with nbconvert)
https://github.com/almond-sh/almond/commit/624c197984183d1c30b41c238ec8beda691556bf
@alexarchambault Could help me squash bf7c893 and b75f6fa in #843 into "Add rich display for python objects in ScalaPy" as well? Or give me write to the branch I can do it myself.
@kiendang Not sure I see what you mean, but I gave you write access to the repo just-in-case (this should allow you to re-run CI jobs for example).
Ah this PR is from your fork which I don't have access to so cannot push change. Anw thanks!
Was supposed to rebase the last two commits but I don't want to mess up your branch while you're still working on it. So we'll just rebase them when the PR's ready to merge.
I still have no idea what actually causes the problem, but in case you're looking into it later, you can use jupyter console to run the example interactively and get the error.
JUPYTER_PATH=... jupyter console --kernel ...
The example works fine when you run it interactively in a notebook, also works fine with jupyter console, nbconvert in macOS. The problem seems to only exist in Linux (I tried both Ubuntu and Arch).
I was able to run the example notebook manually in a Jupyter console fine on my Ubuntu machine (by running ./mill -i -w jupyterConsoleFast from commit 0d9607c2). I was using Java 17, trying again with Java 8 right now... Edit: seems to work fine from Java 8 too.
Hmm so still not sure why it fails while running non-interactively. Maybe try with ScalaPy 0.5.2 instead of 0.5.0 too? But I remember trying that locally a while back and still got the error.
I think I found the issue. It originates from some JNA version mismatch. Ammonite and scala-compiler were pulling JNA 5.9.0 (see cs resolve almond:0.13.1 --what-depends-on net.java.dev.jna:jna), while ScalaPy needs a newer version (see cs resolve me.shadaj::scalapy-core:0.5.2). The underlying JNA error was this one.
Merging with main once https://github.com/almond-sh/almond/pull/974 is merged should fix things (maybe with a few version bumps too).
Not sure why it only happens in non-interactive mode... Maybe Ammonite or scala-compiler were able to initialize JNA stuff in interactive mode (without a version mismatch for them), and then ScalaPy was using an already initialized JNA, so it wasn't having issues.
https://github.com/scalapy/scalapy/pull/294 would have helped debug this too I think (by not trapping the underlying JNA error).