Alexis Métaireau

Results 539 comments of Alexis Métaireau

This is indeed not a security problem, and there is no template injection here. Closing.

Hi, thanks for opening this issue. I think you're correct : this is a bug. We should look in the database before erasing the values with the defaults. https://github.com/spiral-project/ihatemoney/blob/master/ihatemoney/api/common.py#L100-L110

I agree with you on the semantics, but that's not how it's implemented now unfortunately. We could change the API if we want :-) But, in the meantime, I think...

I think I would prefer to make this impossible to do without reactivating the users first. That would be easier to do and not clutter the UX?

Thanks for this, it seems good to me, but lacks a test to ensure that what you're doing works the way you intend. Are you okay to write such a...

Thanks for your work on this. I've added a few comments and questions, don't hesitate to answer and discuss these :-)

Hi @Huda11Baig. Hope you're well :-) Have you seen my comments? Don't hesitate to tell me what you think :-)