timetagger icon indicating copy to clipboard operation
timetagger copied to clipboard

Backspace can unselect all tags now

Open Tagirijus opened this issue 1 year ago • 1 comments

I reset my branch, since with my recent PR #480 I accidentally had all my recent changes combined in one PR, which was not my intention. Also I now added things to the GUI to properly reflect the new feature.

Tagirijus avatar May 07 '24 10:05 Tagirijus

Ok now only one test failed, the linting one. Did I do something wrong with the code formatting or so?

Tagirijus avatar May 07 '24 10:05 Tagirijus

Thanks! I forgot about this PR. I fixed the formatting and merged.

In the future, you can run black . on the repo to fix formatting.

almarklein avatar Jul 18 '24 09:07 almarklein

Cool thanks for the info and thanks for merging. I recently found a bug, though. When pressing Backspace now the filtered tags do not get re-shown in the list. I have to investigate - just wanted to note this down. If I can find a solution I simply will probably come up with another PR. Thanks for merging and thanks for checking my code. (=

Tagirijus avatar Jul 18 '24 12:07 Tagirijus

I cannot reproduce the bug, and also don't see how that could be happening. For good measure I did #497 so ._tag_bars_dict is also reset.

almarklein avatar Jul 24 '24 12:07 almarklein

I finally found some time testing + updating. For now I also cannot reproduce it. Maybe it was some hiccup or so. Thanks again for merging! (=

Tagirijus avatar Aug 05 '24 10:08 Tagirijus