Almann Goo

Results 25 comments of Almann Goo

Jon, this is really awesome--I think we should definitely register the media type. I would like us to consider using this draft as the basis for a submission, thus, as...

Agree with the above as API requirements. I am also coming to the opinion that we should be capturing these views as `trait` as well because we will start to...

I put together a straw proposal of what I was thinking: https://github.com/almann/ion-rust/commit/6c4ab4ead3e455bd16742f0a73a388a71d58fa68 The above is not complete by any means, but to illustrate what I was thinking. I would love...

Added some comments on your commit. I think this is close--but I think the traits are a little off. The derivation macros are regrettable, but probably correct.

In general, the typical pattern we'd encourage is to be generic with respect to `XXXView` traits when dealing with typed elements. _If_ we had `impl trait` as type aliases, we'd...

I will add that I believe this is an edge case where a timestamp is at the end of a buffer. There is a potential issue with the timestamp parsing...

Something we should consider strongly here is eliminating the page pool entirely--and I do mean delete the code and make sure it cannot be used. The rationale is this--we keep...

See amzn/ion-rust#193 for the code that fixes the repro in that package for this bug.

I did recently fix #183, which should eliminate `gtest` and friends from the install target--does this address your issue?