Allusion icon indicating copy to clipboard operation
Allusion copied to clipboard

Add support for mp4, webm, and ogg

Open pianissi opened this issue 2 years ago • 3 comments

For #466, adds support for automatic and on hover playback for videos in gallery view. Also allows playback in main view, which has the side effect of allowing sound from non-video .ogg files. Implementation uses web video elements which replace the image elements used normally. I'm unfamiliar with React or Electron so the implementation may not be optimal.

Caveats:

  • No thumbnail images
    • As a result video preview will always be on the first frame
  • On gallery view, automatic playback of many videos lowers performance by a noticeable amount

pianissi avatar May 09 '23 13:05 pianissi

Sincerely hope that it will be implemented into the main branch sooner or later. With some video support, Allusion would be pretty much feature complete, at least for a user like me.

Vargock avatar May 23 '23 22:05 Vargock

We merged this pull request + HEIC and other new formats in our Allusion Fork, in case someone is interested: https://onefolder.app/

Antoine-lb avatar Oct 11 '24 12:10 Antoine-lb

I resolved the conflicts and merged this pull request on my fork. Thanks @pianissi for your work ❤️ and @Antoine-lb for the merge hints 👍

Also fixed small css errors of this PR (video not cropped on grid-> content.scss:331 & 337)

Should I make an action to propose my changes on this pull-request? I did a rebase on master, and the css fixes are in a commit. This is my first time contributing to open-source. I could also make another pull request. Please tell me what's best.

CharlesBoury avatar Dec 19 '24 11:12 CharlesBoury