allure-python icon indicating copy to clipboard operation
allure-python copied to clipboard

bug: When the check is placed in the parent step and the child step asserts, the check becomes invalid.

Open Faerie1999 opened this issue 1 year ago • 2 comments

I'm submitting a ...

  • [x] bug report
  • [x] feature request
  • [ ] support request => Please do not submit support request here, see note at the top of this template.

What is the current behavior?

def validate_something(a, b, c, d):
    with check, allure.step(f'some assertions'):
        with allure.step('aa'):
            assert a == 1
        with allure.step('b'):
            assert b == 2
        with allure.step('cccc'):
            assert c == 13
        with allure.step('dddd'):
            assert d == 4


def test_22():
    with check, allure.step("setup step"):
        assert 5 == 5
    validate_something(1,2,3,4)

As above, the test report is:

image

the step dddd won't be executed, the effect of pytest-check is gone

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

copy the code above

PS: if run, the step [some assertions] won't be marked as failed, but pass, and the four sub-steps will be executed, I hope if any sub step is failed, the parent should be failed:

def validate_something(a, b, c, d):
    with allure.step(f'some assertions'):
        with check, allure.step('aa'):
            assert a == 1
        with check, allure.step('b'):
            assert b == 2
        with check, allure.step('cccc'):
            assert c == 13
        with check, allure.step('dddd'):
            assert d == 4


def test_22():
    with check, allure.step("setup step"):
        assert 5 == 5
    validate_something(1,2,3,4)

main.py run pytest (allure) and get the allure report

What is the expected behavior?

step dddd should be executed

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

Other information

Faerie1999 avatar Jul 15 '24 09:07 Faerie1999

Has the issue been resolved

516662523 avatar Nov 18 '24 06:11 516662523

Has the issue been resolved

No

Faerie1999 avatar Nov 18 '24 07:11 Faerie1999