allure-npm icon indicating copy to clipboard operation
allure-npm copied to clipboard

Fix escaping of arguments

Open mohd-akram opened this issue 10 months ago • 3 comments

Commit a40732948a4a5ad9a23394eab16ddd24825726e0 enabled the shell option to fix running on Windows, but that's unsafe and breaks handling of spaces and special characters. Arguments provided to Windows batch files in particular need special escaping that's not provided by Node.js; use batspawn for that purpose.

Fixes #30 Fixes #45

mohd-akram avatar Feb 23 '25 11:02 mohd-akram

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Feb 23 '25 11:02 CLAassistant

@baev Thoughts on this?

mohd-akram avatar Mar 10 '25 16:03 mohd-akram

Commit a407329 enabled the shell option to fix running on Windows, but that's unsafe and breaks handling of spaces and special characters. Arguments provided to Windows batch files in particular need special escaping that's not provided by Node.js; use batspawn for that purpose.

Fixes #30 Fixes #45

Hi,

Any updates on this? Will it be included in the upcoming release?

Hemavathy12 avatar May 16 '25 06:05 Hemavathy12