allure-csharp
allure-csharp copied to clipboard
Added convenience overload for AddScreenDiff
. . An example of good pull request names: . - Add Russian translation (fixes #123) . - Add an ability to disable default plugins . - Support emoji in test descriptions )
Context
Checklist
- [x] Sign Allure CLA
- [x] Provide unit tests
Hi @CraigRichards, Idea is good, but this change breaks package public interface, which can be confusing for the current consumers.
Hi @CraigRichards, Idea is good, but this change breaks package public interface, which can be confusing for the current consumers.
Hi, Can you please check the commit again? I left the old method in place and added an overload? This will not break any existing consumers.
If you review you the code, I left the existing test in place 'AllureLifeCycleTest' which calls the original method. So your existing contract remains valid.
Then I duplicated this test and called it 'AllureLifeCycleTestUsingNewAddScreenDiff' which tests the new method.
Thanks and looks forward to contributing further.
Cheers Craig
That overload has been introduced as part of #371. Released in 2.10.0