allure-csharp icon indicating copy to clipboard operation
allure-csharp copied to clipboard

Added convenience overload for AddScreenDiff

Open CraigRichards opened this issue 3 years ago • 3 comments

. . An example of good pull request names: . - Add Russian translation (fixes #123) . - Add an ability to disable default plugins . - Support emoji in test descriptions )

Context

Checklist

CraigRichards avatar Jun 09 '21 20:06 CraigRichards

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 09 '21 20:06 CLAassistant

Hi @CraigRichards, Idea is good, but this change breaks package public interface, which can be confusing for the current consumers.

Bakanych avatar Jun 11 '21 03:06 Bakanych

Hi @CraigRichards, Idea is good, but this change breaks package public interface, which can be confusing for the current consumers.

Hi, Can you please check the commit again? I left the old method in place and added an overload? This will not break any existing consumers.

If you review you the code, I left the existing test in place 'AllureLifeCycleTest' which calls the original method. So your existing contract remains valid.

Then I duplicated this test and called it 'AllureLifeCycleTestUsingNewAddScreenDiff' which tests the new method.

Thanks and looks forward to contributing further.

Cheers Craig

CraigRichards avatar Jun 11 '21 05:06 CraigRichards

That overload has been introduced as part of #371. Released in 2.10.0

delatrie avatar Dec 27 '23 10:12 delatrie