tux icon indicating copy to clipboard operation
tux copied to clipboard

fix: make whether starboard self-reacting is allowed configurable

Open RainzDev opened this issue 7 months ago • 4 comments

Description

The reason why I believe this should be removed is because there could be other reasons to why users would react to their own message with a star

Guidelines

  • My code follows the style guidelines of this project (formatted with Ruff)

  • I have performed a self-review of my own code

  • I have commented my code, particularly in hard-to-understand areas

  • I have made corresponding changes to the documentation if needed

  • My changes generate no new warnings

  • I have tested this change

  • Any dependent changes have been merged and published in downstream modules

  • I have added all appropriate labels to this PR

  • [x] I have followed all of these guidelines.

Summary by Sourcery

Enhancements:

  • Modify starboard reaction handling to allow users to keep their star reaction on their own messages

RainzDev avatar May 01 '25 18:05 RainzDev

✨ This comment will be updated with CI stats as CI jobs run ✨ settingsfeedbackdocs ⋅ learn more about trunk.io

trunk-io[bot] avatar May 01 '25 18:05 trunk-io[bot]

Reviewer's Guide

This pull request removes the automatic deletion of a user's reaction if they react to their own message within the starboard feature by deleting the relevant code lines in the reaction handler.

File-Level Changes

Change Details Files
Removed automatic deletion of self-reactions for starboard
  • Deleted the message.remove_reaction call targeting the message author.
  • Removed the associated contextlib.suppress block.
tux/cogs/services/starboard.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an issue from a review comment by replying to it. You can also reply to a review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull request title to generate a title at any time. You can also comment @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in the pull request body to generate a PR summary at any time exactly where you want it. You can also comment @sourcery-ai summary on the pull request to (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the pull request to resolve all Sourcery comments. Useful if you've already addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull request to dismiss all existing Sourcery reviews. Especially useful if you want to start fresh with a new review - don't forget to comment @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

  • Contact our support team for questions or feedback.
  • Visit our documentation for detailed guides and information.
  • Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai[bot] avatar May 01 '25 18:05 sourcery-ai[bot]

should be decided when running $starboard setup not hard coded, might be a good idea to wait for #843 though

electron271 avatar May 10 '25 15:05 electron271

should be decided when running $starboard setup not hard coded, might be a good idea to wait for #843 though

Yeah, I figured I'd have to wait for that to finish up. And yea, I agree configuration should be added.

RainzDev avatar May 11 '25 14:05 RainzDev