Sibtain Ali

Results 97 comments of Sibtain Ali

Looking solid. The only thing I noticed was that the approver name sent from the backend included last name as well. Other than this, it seems to work well. Can...

Hi @tienifr. I don't understand why we need to touch the `ExpensiMark` library? We're matching `@...` without the email already. Since we will be dropping the domain part from suggestion...

Please don't lie @MelvinBot. Are you having memory issues? 💀

That makes sense. Thanks for the detailed explanation. @tienifr's [proposal](https://github.com/Expensify/App/issues/35532#issuecomment-1928906247) should work well! 🎀 👀 🎀 C+ reviewed

@hayata-suenaga Whats up with these so many failing checks?

@gireinvent Can you please fix lint issues?

Bump on above @gireinvent. Also, @hayata-suenaga can you please add me as a reviewer here so that I can track this?

@hayata-suenaga I think the following explains why the above are failing: 1. Checklist: Failing because its incomplete. There seem to be 2 missing items. 2. Typescript: We're adding `testId` as...

I can take this over and do the changes if needed.

Thanks @mallenexpensify. I'll take this. @johncschuster do we have an answer on [this](https://github.com/Expensify/App/issues/34817#issuecomment-1900860777) yet?