svm-rs icon indicating copy to clipboard operation
svm-rs copied to clipboard

chore: refactor into target os and arch

Open roynalnaruto opened this issue 2 years ago • 2 comments

roynalnaruto avatar Apr 09 '22 18:04 roynalnaruto

gm @roynalnaruto wonder what your plans are for this PR

gakonst avatar May 11 '22 21:05 gakonst

gm @gakonst The PR is ready. Although it would affect svm-build's CI build-release process coz the RELEASES are populated by passing the target architecture and target OS as a function argument and not via Rust's conditional compilation (this PR conditionally compiles every function, so that specific part will be disrupted).

@mattsse and I discussed this and hence I stopped updating this PR. Otherwise the PR itself is ready and can be merged post resolving conflicts.

roynalnaruto avatar May 12 '22 13:05 roynalnaruto