ffprofile icon indicating copy to clipboard operation
ffprofile copied to clipboard

Geolocation

Open StarPicard opened this issue 7 years ago • 6 comments

StarPicard avatar Apr 12 '18 15:04 StarPicard

Can you explain or do you have some ressource what your settings are doing?

As far as I understand you're mixing a few things: Geo-Location, accept language headers and country specific search engine settings (possibly derived from geo location queries?).

My general policy to geo location was so far not to include it, as it is opt-in anyway. If there is an option to switch from google to a more privacy friendly mozilla geolocation provider this would be a good reason to include it.

And the other options deserve own settings. Possibly accept-language and search default could be merged, but geolocation is something else.

allo- avatar Apr 12 '18 16:04 allo-

I merged all this features in one because I thought it might make sense do disable all option wich could be used to geolocate a person. Otherwise it might be possible that an person enables some features wich should disable geolocation and some options might still be there to track this person.

The other point is, that you could switch the geolocation service from google to mozilla. I'm still investigating if there are some other open source projects wich provide geolocation.

StarPicard avatar May 14 '18 07:05 StarPicard

I think this should not be merged this way for two reasons:

  • transparency what happens, why and what may be broken by it
  • It contains settings which have an easy opt-out in firefox itself.

split into different settings it may be useful, i.e. "use english default language (helps hiding your location)" may be a setting.

allo- avatar May 14 '18 10:05 allo-

Yeah, in the meantime, I've been thinking, and I agree with you. We should drop the pull request and I continue in time.

StarPicard avatar May 14 '18 18:05 StarPicard

The settings are interesting, but not in this combination for the default profile.

The profile infrastructure needs to be more flexible. I would love to be able combine "default + secure-https + disable-all-google-things", so I don't have to clutter one big profile or choose between secure https or privacy settings.

See #71, #57, #25. Any pull requests welcome. Until then things need to be organised into reasonable profiles.

allo- avatar May 14 '18 18:05 allo-

Revisiting the pull request:

  • What about splitting it?
  • Are the geo location leaks still existent in recent Firefox versions? Is there more to read about the problem and the proposed fix? In general I often dislike things like settings urls to "" if there is enabled toggle or something similar, but I am not sure if the leaks you're mentioning make it necessary to remove the URL.
  • What does adding the geo.wifi.uri (with the local.services.mozilla.com URL) do? I looks like the URL could be the default instead of a changed setting?
  • Minor point: "initial" should probably be "true".

So if this is (still) a problem I'd like to merge it in some way, but I like to understand the details and possibly to add a user-friendly description that explains a bit of why it leaks the position.

allo- avatar Oct 23 '22 18:10 allo-