allinurl
Semantic HTML in generated report page
Would you be open to a merging a pull request that updated the generated HTML reports to use semantic HTML? I wanted to gauge interest before taking a crack at it.
Thanks for reaching out! I’m totally up for any improvements that could make the report better, as long as they don’t break its current functionality :) Feel free to share any ideas you have about the changes.
There are two types of accessibility changes that come to mind first:
- Swap some
<div>s with more semantic elements, add accessible names to tables, etc. - Change pagination
<a>to<button>, remove menu links from tab order when they are hidden, etc.
Item one wouldn't modify any scripts while item two would involve some querySelector changes, as well new code for attributes that are not currently present. I have other ideas as well, but I don't think they're worth mentioning until I get more familiar with the way the report is generated by making the above changes.
One quick question: do you have a minimum browser version to target for the report, or would you like me to choose one? That will affect the way some of the above changes get implemented.
That sounds great! I don’t have a specific browser version to target, however, as long as it works on recent versions of any major browsers, I’m fine. Thanks for your help!
The most straightforward way to improve semantics for the "Panel options" dropdown would involve swapping out the Font Awesome icon indicators with native form controls, essentially pulling out that component and recreating it from scratch. Would you like a change that large to be a separate pull request from the general semantic improvements, or can it be included in this work?
That's a good point, I'd rather have it as a separate PR from the overall semantic improvements.