examples icon indicating copy to clipboard operation
examples copied to clipboard

mmap in mplane mode used correctly in Camea.cpp?

Open jacobschloss opened this issue 2 years ago • 0 comments

https://www.kernel.org/doc/html/v4.9/media/uapi/v4l/mmap.html#mmap says:

When using the multi-planar API, every plane of every buffer has to be mapped separately, so the number of calls to mmap() should be equal to number of buffers times number of planes in each buffer.

But the code when in mp mode only maps a single plane per buffer without checking v4l2_buffer::length https://github.com/alliedvision/examples/blob/fd8b9cff52119ddef1cf1b0ac0ee76ce52a6d1ad/BasicV4L2/Source/Camera.cpp#L123

Should this code be mapping as many planes as v4l2_buffer::length indicates?

jacobschloss avatar Mar 31 '22 20:03 jacobschloss