Band-aid for Bulk SDKHooks performance impact #2

[KaelaSavia]

Resolves previously mentioned issues in original pull https://github.com/alliedmodders/sourcemod/pull/2092

Apologies for closing previous one, was going on abruptly planned holidays but decided to grab laptop anyhow so if there are any further issues i'll be able to work further on PR 😅

[KyleSanderson]

it's the same branch... reopening the old one.

ugh. comments in the other PR. Mostly around just tighter levelend code.

[Jugheadbomb]

Any progress on testing and mergin this?

[Rushaway]

This patch is making a significant difference after multiple tests, thank you for it.

[KaelaSavia]

@Headline Any potential ETA for testing or any way I could help with testing to speed process-up?

I personally along with other people in comments so far tested change and have experienced no issues and only performance improvements!

• Thanks

[Rushaway]

Based on the map in https://github.com/alliedmodders/sourcemod/issues/1935 , ported for CS:S Without https://github.com/alliedmodders/metamod-source/commit/f2d9d3e9e532d0211b5bb398aec0bff0fbe0aada server make a big timeout for 10s at every round start.

Based on the same machine, configs, hardware, os, metamod version (latest). Using SM 1.12 build 6954: Here some results:

Stock SM:

4191 frames sampled for 28.60 seconds
Average 146.53 fps, 6.82 ms per frame
Peak 134.12 ms frame
99 pct of time accounted for

This commit patch:

MM:S 1.12.0-dev+1192 (speed up by 42.7%.)

4195 frames sampled for 28.56 seconds
Average 146.89 fps, 6.81 ms per frame
Peak 76.90 ms frame
99 pct of time accounted for

MM:S 1.11.0-dev+1155 (speed up by 46.52%.) (improvement come from f2d9d3e)

4195 frames sampled for 28.63 seconds
Average 146.57 fps, 6.82 ms per frame
Peak 71.73 ms frame
99 pct of time accounted for

Stock: profiler__2024-02-06_18-01-09.log Band Aid patch with MM 1.12: profiler__2024-02-06_19-43-26.log Band Aid patch with MM 1.11 (including f2d9d3e) :profiler__2024-05-18_11-11-48.log

[Rushaway]

I uptaded my preivous message with the difference related to MetaMod:Source with and without Replace fscanf with faster parsing commit. It also make a nice difference.