A2S_Rules fix: Move MTU patch value to gamedata and increase it

[Vauff]

Fixes #1814, supersedes #1815.

Implements the suggestion from https://github.com/alliedmodders/sourcemod/pull/1459#pullrequestreview-638382759, and increases the MTU to 65000 (what was used in the old plugin).

[psychonic]

The MTU is already being patched to more than twice a sane MTU value. Making it configurable is fine, but we don't want it getting too huge and people potentially opening themselves up to DOSing if they actually do have that many convars with the notify flag or large values due to what would surely be hugely fragmented oob packets.

[Vauff]

The MTU is already being patched to more than twice a sane MTU value. Making it configurable is fine, but we don't want it getting too huge and people potentially opening themselves up to DOSing if they actually do have that many convars with the notify flag or large values due to what would surely be hugely fragmented oob packets.

What value would be recommended here then? Or no increase at all?

[Vauff]

10k could possibly be a better middle ground? It would still cover all the reported "cannot send packet" instances so far without going too far overboard.

[KyleSanderson]

10k could possibly be a better middle ground? It would still cover all the reported "cannot send packet" instances so far without going too far overboard.

I do think 10k might be ok, but there's too many unknowns right now with us not understanding the full implications of what this does (such as the vulnerability potential mentioned). 10k is much larger than the internal we're already patching.

If you're open to it, if you change the gamedata value back to 5k we can land this, and then you can report back how 10k has worked for you (and others) after a period of time.

[crashzk]

@Vauff using the latest version SourceMod 1.11.0.6934 I keep getting a lot of these errors.

[NET] Cannot send 5561-byte packet to XX.XXX.XX.XX:XXXXX.  MTU is 1200.  ff ff ff ff 45

[NET] Cannot send 5561-byte packet to XX.XXX.XX.XX:XXXXX.  MTU is 1200.  ff ff ff ff 45

[NET] Cannot send 5561-byte packet to XX.XXX.XX.XX:XXXXX.  MTU is 1200.  ff ff ff ff 45

[NET] Cannot send 5561-byte packet to XX.XXX.XX.XX:XXXXX.  MTU is 1200.  ff ff ff ff 45

[peace-maker]

Try increasing the MTUPatchSize in a custom gamedata override. It defaults to 5000 and you're having loads of convars with 5561 bytes.

[crashzk]

Try increasing the MTUPatchSize in a custom gamedata override. It defaults to 5000 and you're having loads of convars with 5561 bytes.

Thanks for the reply. In any case, I noticed that SM 1.11 does not have this feature implemented yet, only in version 1.12+.

I even manually looked to change it in gamedata but it doesn't have this MTUPatchSize. For now, leave this spam on the console until I update to SM version 1.12.