sourcemod icon indicating copy to clipboard operation
sourcemod copied to clipboard
verified publisher icon alliedmodders

[Feature] Allow sending panels to SourceTV client

Open A1mDev opened this issue 3 years ago • 6 comments

Code tested in game Left4Dead2, menu successfully sent to SourceTV client.

Close #1563

A1mDev avatar Jun 04 '22 08:06 A1mDev

Why do you want menus to show up? SourceTV clients won't be able to interact with them.

peace-maker avatar Jun 15 '22 09:06 peace-maker

Yes, i understand that SourceTV clients cannot interact with the menu. The menu is needed to send information to SourceTV clients.

A1mDev avatar Jun 15 '22 20:06 A1mDev

I think we could enable panels for bots, but menus seem like they could be problematic as they'd remain stuck active forever until a new menu was displayed, which could have knock on effects for plugins.

asherkin avatar Jun 15 '22 20:06 asherkin

I sent menus and panels to SourceTV clients, there were no problems, the menu and panels are sent for the specified time and then deleted, and yes, of course, I can’t interact with them. 20220620222648_1 20220620222608_1

A1mDev avatar Jun 20 '22 15:06 A1mDev

SourceMod keeps track of menus and could keep some resources allocated for the sourcetv client indefinetely. Panels are one-shot and won't cause trouble after being displayed, so it's safe to send them to the sourcetv bot.

peace-maker avatar Jun 20 '22 21:06 peace-maker

Ok, I think it's enough for me that I can only send the menu panel to the SourceTV bot. I don't know if anyone needs the same ability to send a menu. If necessary, I can make another separate PR to add this feature with problem fixes.

A1mDev avatar Jun 22 '22 11:06 A1mDev

Hello, I changed my PR a little, added the ability to enable menu sending for SourceTV, this was done in order not to change the default behavior of the menu.

A1mDev avatar Jul 20 '23 06:07 A1mDev