sourcemod icon indicating copy to clipboard operation
sourcemod copied to clipboard

Bring languages into the tree

Open KyleSanderson opened this issue 3 years ago • 1 comments

The translation tool has been an excellent resource since its inception and has added atleast 30 languages to the Source ecosystem. However, since moving to Git from Mercurial (and other source versioning tools) it's received less and less love and has been a cause of concern to merging PRs due to i18n issues as these files do not live in the tree.

This PR brings the latest languages into the tree in hopes of avoiding situations where merge requests get stalled out. There's a buildbot step that needs to be removed before this is merged to no longer pull from the other database, centralizing the language database to the repository.

KyleSanderson avatar Nov 01 '21 23:11 KyleSanderson

Is this a direct export from the translator tool or pulled from a SM release?

Unmodified?

Any idea if partial translations are all included here?

This is from 1.11.0-git6804-linux as-is. I haven't watched the tree for a minute but the last time the directory was changed (in git) was 2 years ago so I'm feeling confident it's OK.

KyleSanderson avatar Nov 02 '21 00:11 KyleSanderson

This probably needs an update and the mentioned change to the buildbot packaging script.

When switching to all languages being in the repo, we lose the easy way to see which phrases are missing in which language. We could try to solve that using a CI job which never fails but just prints the missing phrases for each language whenever the translations folder is changed.

Or even let it update a TODO.md and push it into the repo? Can you post in github "projects" from a CI job?

peace-maker avatar Dec 02 '22 13:12 peace-maker

I future suppose to completely synchronize files from sourcemod.net to AMBuild package after binaries built (actual GeoIP2 database and maybe more)

Wend4r avatar Feb 22 '23 00:02 Wend4r

Sorry, I didn't get this. What are you suggesting?

peace-maker avatar Feb 23 '23 00:02 peace-maker

Sorry, I didn't get this. What are you suggesting?

In simple terms, so that after the manual ambuild, the package/** was same like https://www.sourcemod.net/downloads.php?branch=dev (Of course, excluding the other current compiler byte-code and distribution ABI compatibility on which ambuild was executed)

Wend4r avatar Feb 23 '23 14:02 Wend4r

I found it. Like this — https://github.com/alliedmodders/sourcemod/blob/master/tools/buildbot/package.pl

Wend4r avatar Feb 23 '23 14:02 Wend4r

Or I suggest making a proxy mirror from GitHub to sm.alliedmods.net backend (auto-updater and buildbot) so that changes in files do not conflict

Wend4r avatar Feb 23 '23 14:02 Wend4r