ng-aquila
ng-aquila copied to clipboard
Improve RTL support with logical properties
General improvement
We recognized that the current implementation is really well done with only a few things to improve, where especially nested components in other components doesn't get the correct styling in an RTL view, for example the header component.
đ¯ Goals
The goal would be to adapt to the CSS logical properties schema
- to reduce the amount of code,
- to reduce the technical depth and
- improve maintainability and
- make component nesting more versatile.
- having a modern and future-proof styling approach â¨
đ References
A helpful link and well written guide on how to approach this topic is: https://elad.medium.com/new-css-logical-properties-bc6945311ce7
The current browser support can be found here: https://caniuse.com/css-logical-props
The CSSWG spec can be found here: https://drafts.csswg.org/css-logical/
While not everywhere completely supported, we can introduce a postcss build step which compiles the logical properties to the format for legacy/old browsers. When IE11 support is dropped with the upgrade to Angular v13, this build step could be removed.
đ Requirements
The requirements have to be discussed, also the prioritization on the roadmap and when it fits best in the release cycle.
âšī¸ Details
Feel free to reach out for any information. Thanks very much!! đ
Hi @felixhaeberle
I second that this is a nice idea for the future but it also means to change all current implementations. So if you see some issues a first step would be to provide reproduction examples. It might be easier to fix it in the current way than to rewrite everything.
Hi @felixhaeberle thanks for your suggestion. I opened an internal ticket so we can have a closer look.
internal ticket https://github.developer.allianz.io/ilt/ngx-ndbx/issues/3694
Let's continue this discussion in the internal repository.