OpenNoteScanner icon indicating copy to clipboard operation
OpenNoteScanner copied to clipboard

Unable to use Splash Screen as Launcher activity

Open MaheshGawhane11 opened this issue 4 years ago • 4 comments

When am trying to use Splash screen as launcher activity, then application crashing on below line of OpenNoteScannerActivity:

if (intent.getAction().equals("android.media.action.IMAGE_CAPTURE")) {

Steps to reproduce

Create Splash screen and make it Launcher activity and capture image.

MaheshGawhane11 avatar Jul 27 '20 13:07 MaheshGawhane11

@MaheshGawhane11 , please explain more your problem. Are you trying to launch ONS from another app and it is failing? Can you send a link to the app?

allgood avatar Jul 27 '20 13:07 allgood

I am trying to lauch Splash screen activity before launching OpenNoteScannerActivity.java.

After this when i am trying to scan/capture document, application get crashed.

Thanks

On Mon, Jul 27, 2020, 7:21 PM Claudemir Todo Bom [email protected] wrote:

@MaheshGawhane11 https://github.com/MaheshGawhane11 , please explain more your problem. Are you trying to launch ONS from another app and it is failing? Can you send a link to the app?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ctodobom/OpenNoteScanner/issues/216#issuecomment-664409326, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD7MT6YGJHC3YCQ3W7RWJ33R5WA7LANCNFSM4PIYNUKQ .

MaheshGawhane11 avatar Jul 27 '20 14:07 MaheshGawhane11

But ONS doesn't have a Splash screen, this is why I don't understand. Is your problem related with the current code on project or something you are working on?

allgood avatar Jul 27 '20 14:07 allgood

If you are trying to implement splash screen, I think it is not needed because open note scanner is very quick to load, splash screen will add an unnecessary delay to the user - this is why I probably will not accept such a contribution in the main project.

But if you want it anyway on a branch of your own, you must be sure to make the app work well when called from another apps that asks for an image through IMAGE CAPTURE intent. (unfortunatelly almost all messaging apps are not using this feature anymore... one I know is keybase)

allgood avatar Jul 27 '20 14:07 allgood