Lots of XRC errors with wxWidgets 3.1.5 and 3.2.2

[caoliver]

There are lots of places which bring up an ineffective wxALIGN_CENTRE with wxEXPAND with current wxWidgets libraries dialog box. I rebuilt pgadmin3 after removing the allegedly superfluous wxALIGN_CENTRE from the xrc files with sed, but this may be bogus as I'm no wxWidgets expert. I'm not sure if there are other XRC errors, but getting these dialogs makes trying to work with pgadmin3 a frustrating affair.

[SebDieBln]

Thanks for bringing this up. Can you provide a specific example how to reproduce the error?

[caoliver]

On Sun, 27 Aug 2023 06:13:48 -0700 Sebastian Dietrich @.***> wrote:

Thanks for bringing this up. Can you provide a specific example how to reproduce the error?

Simply build a copy of wxWidgets (3.1.5 opr 3.2.2) monolothic with gtk2. Compile and link pgadmin3 lts against that. Run pgadmin3, and select "Add server" from the File menu. You should see a complaint dialog that wxALIGN_CENTRE has no effect when the wxEXPAND is given.

-- Christopher Oliver @.***>

[dilworks]

This happens on nearly every dialog - from the Backup and Restore dialogs to the Add Server one.

Some have as little as 3 errors, but many pop up over 10 of those errors, making its usage very annoying as you have to dismiss a unpredictable number of errors before getting to the actual dialog. Other than that, the dialogs work fine, albeit with cosmetic details, but nothing that hampers or breaks usability.

[SebDieBln]

I will look into this within the next couple of weeks.

[VVD]

Check this: https://github.com/AbdulYadi/pgadmin3/commit/526e4c1cbc6da51b8f2312b204a1c31c9144acb4