tango icon indicating copy to clipboard operation
tango copied to clipboard
verified publisher icon allenai

Remove `DetHashWithVersion`

Open dirkgr opened this issue 3 years ago • 2 comments

The whole det_hash functionality should just always look for a member named VERSION and use it.

dirkgr avatar May 17 '22 22:05 dirkgr

Is the issue still valid?

I'm only just to remove the DetHashWithVersion class from the tango/common/det_hash.py file right?

eskayML avatar Aug 02 '23 05:08 eskayML

The functionality where it looks for VERSION should just be baked into det_hash directly, without an extra class. So it's not just removing the class. It also involves moving that code elsewhere.

dirkgr avatar Aug 02 '23 21:08 dirkgr