deep_qa icon indicating copy to clipboard operation
deep_qa copied to clipboard

Fix paths in the code to be OS independent

Open matt-gardner opened this issue 7 years ago • 3 comments

I'm pretty sure this won't work on Windows at the moment, because we have plenty of places where / is hard-coded, instead of using os.path.join. This should be fixed.

It's also super low priority for us, and really hard to know if we've found everything, because we just use linux and macOS. Contributions welcome here.

matt-gardner avatar May 03 '17 15:05 matt-gardner

I use windows. How can I help?

morrme avatar May 05 '17 02:05 morrme

Try running things, see what breaks, and submit PRs to fix it. If it just works already, then great, we can close this issue.

matt-gardner avatar May 05 '17 02:05 matt-gardner

to be specific, it'd be great to verify that unit tests at least work on windows.

nelson-liu avatar May 05 '17 07:05 nelson-liu