allennlp icon indicating copy to clipboard operation
allennlp copied to clipboard

Published 20 hours ago • verified publisher icon allenai

Switch over to using torch.testing.assert_close in tests

Open epwalsh opened this issue 3 years ago • 2 comments

assert_allclose is being deprecated. See https://github.com/pytorch/pytorch/issues/61844.

epwalsh avatar Jul 19 '21 18:07 epwalsh

The suggested replacement was only added in torch 1.9.0, so we need to wait until that is the oldest version we support before we tackle this.

dirkgr avatar Jul 23 '21 20:07 dirkgr

I don't think this is a user-facing change but let me know if I'm wrong. Because as far as I know we only use this in internal tests, and we only run those tests against the latest version of PyTorch.

epwalsh avatar Jul 26 '21 18:07 epwalsh