save-for-later icon indicating copy to clipboard operation
save-for-later copied to clipboard

Support shortcutkeys to save !

Open dnknn opened this issue 4 years ago β€’ 5 comments

`chrome://extensions/shortcuts#:~:text=Save%20for%20later`

↑ Copy the above URL and open it will arrive directly. this hotkey is Popup, not a specific function , so must add ⌨hotkey for πŸ‘‰


  • Users will be able to use shortcutkey to directly trigger the function.
  • Use the hotkey, it must should πŸ””Chrome.Notifications ! https://developer.chrome.com/docs/extensions/reference/notifications/

γ€€ γ€€ With the πŸ””, users can rest assured when saving with ⌨hotkey!

bell212_19064108bell

  • γ€€γ€€γ€€γ€€? tabs be saved ꘌ see at hereπŸ‘‰ https://github.com/allen505/save-for-later/issues/13


⚠ Of course, this hotkey operating must also support Save selected tabs ! In fact, a hotkey will be enough, because you holding the Shift on the tab-bar and click 2 times from the beginning to the end, it is equivalent to selecting all the tabs under the window.

  • see here πŸ‘‰ https://github.com/allen505/save-for-later/issues/13

dnknn avatar Feb 18 '21 06:02 dnknn

Hi @dnknn . This is a nice suggestion.
However I am not prioritizing this at the moment because there are a lot of features in the pipeline for the next version already. I'm also not entirely sure if a notification is required when a save is performed. Maybe we can add that as an option "Notify when a Save is made using shortcut : On/Off" References: Adding a keyboard shortcut for the extension Adding a notification

allen505 avatar Feb 19 '21 16:02 allen505

I'm also not entirely sure if a notification is required when a save is performed.

Of course, no notification is required for the actions of users clicking with the mouse on Popup. Because the operation is directly visible!

But using hotkey is different.

  1. Save, obviously it is an important operation.
  2. If no notification, it will be silent. e.g. Press the wrong hotkey, e.g. it was not successfully saved, etc.
  3. Obviously, this kind of notification is just a perceptual reminder, so it will automatically disappear/close after a few seconds!

Therefore, this notification behavior is very reasonable and necessary, and will not burden the user (the notification will automatically close after a few seconds)

Maybe we can add that as an option "Notify when a Save is made using shortcut : On/Off"

it's up to you!

dnknn avatar Feb 19 '21 18:02 dnknn

My reasoning is that notification will require an extra permission and is system generated AFAIK. I was thinking something like a small popup from the extension's button or a maybe a text overlay. Need to do a bit more research on notification before finalizing

allen505 avatar Feb 20 '21 03:02 allen505

@allen505

notification will require an extra permission

There is no problem at all, because notification itself is a very basic function. When you need it, you must have notification permissions. If you use enough extensions, you can obviously feel that many extensions have notifications, of course, the premise is they It does need to be notified.

212_20111147

I know what you mean, it's okay if you don't extension much, but if you extension a lot, do you think you can see it?

Even the extension icon is hidded, so your approach is useless.

So when using hotkeys to assist with notifications is the best way!

dnknn avatar Feb 20 '21 03:02 dnknn

I see your point. I'll update here after a better research on implementation details

allen505 avatar Feb 20 '21 03:02 allen505