Alex
Alex
Tested this ```sh git checkout master git pull upstream master git checkout -b messyPR git rebase spechstatt/feature/pianoview-context-menu git push --set-upstream origin/messyPR ``` Tried making a PR. It included your commits...
> should set this PR "ready for review" Looks good. Go for it! Wait. I reviewed it anyway. :smile: doesn't matter you can change things later
Everything looks good, for what it's worth
I'm available to solve the merge conflicts if that's the only thing needed to get this PR through...
> Namespaces only exist to avoid name collisions What's the deal with namespacing `Mixer`? Threads? > What should we do for plugins? The only reason I see for a `plugin`...
> the distinction between code that needs extra attention (realtime sensitive core) and the rest (gui) would more obvious at all times and harder to miss > namespacing LMMS would...
After thinking about it I don't see a point for `lmms::plugins` The purpose of the `lmms` namespace was to separate our code from conflicts in the Zyn code which we...
Huh, I designed it with that in mind, apparently I failed :) maybe I'll have a little time this weekend to look at it.
I just tested it on your branch, it works as intended. I never told you how it works though. Feel free to add more comments in the code. Here is...