clearml-server icon indicating copy to clipboard operation
clearml-server copied to clipboard

Published 20 hours ago • verified publisher icon allegroai

Correct nginx proxy Host header

Open chriswue opened this issue 2 years ago • 5 comments

The Host header should be the target host not the source host. Fixes #209

chriswue avatar Jul 23 '23 23:07 chriswue

Hi @chriswue, I just want to be absolutely sure, but it seems this change contradicts the example shown here: http://nginx.org/en/docs/http/ngx_http_proxy_module.html Can you please shed some more light on this?

jkhenning avatar Jul 26 '23 08:07 jkhenning

@jkhenning Not sure which example you refer to specifically but this corroborates what I'm talking about: image

chriswue avatar Jul 26 '23 08:07 chriswue

Any updates on this pull request? We would need that change as well. Thank you!

Dominik-Weinzierl avatar May 05 '24 16:05 Dominik-Weinzierl

@chriswue , since your change basically changes it back to the default, wouldn't it be better just to remove this line?

jkhenning avatar May 06 '24 12:05 jkhenning

That should work as well (but i am not sure), yes 🤔

Edit: Somehow deleting all pods and volumes and installing version 7.8.2 fixed the issue for us - so right now no need to change something.

Dominik-Weinzierl avatar May 06 '24 13:05 Dominik-Weinzierl