turnilo icon indicating copy to clipboard operation
turnilo copied to clipboard

Published 20 hours ago • verified publisher icon allegro

Create lazy getter for DataSetWithTabOptions in cube-view

Open adrianmroz opened this issue 5 years ago • 3 comments

adrianmroz avatar Dec 13 '19 10:12 adrianmroz

Let's merge it as temporary solution for #536

adrianmroz avatar Mar 02 '20 09:03 adrianmroz

Check scenario: full reload, viz registers downloadable dataset, click on share menu, check if everything is wired correctly e.g. if file downloads

adrianmroz avatar Mar 02 '20 09:03 adrianmroz

Lets kill this PR. We should lift dataset from BaseVisualisation to CubeView so we don't need to "register" datasets. It is unwieldy. We would need some small change to visualisations. Lets drop "derivedState" and just memoize this transformation inside component. So when new dataset comes to visualisation, it can call this transformation and get derived dataset.

adrianmroz-allegro avatar Jan 28 '21 17:01 adrianmroz-allegro