ralph icon indicating copy to clipboard operation
ralph copied to clipboard

Ralph upgrade breaks ralph installations, well, by design

Open vi4m opened this issue 6 years ago • 4 comments
trafficstars

Currently, apt-get upgrade of ralph installation doesn't run ralph migrate.

The problem is - users are not notified it's required to run ralph migrate command, which will cause severe errors reported to github / forum

We need to do something about it:

  1. Auto run migrations given the fact they are non-destructive
  2. Notifiying user(printing on console?) what command to run (similar to homebrew?)

More info: https://github.com/allegro/ralph/issues/3461

vi4m avatar Jun 17 '19 07:06 vi4m

Touching users' data automatically isn't the best choice -- you never know where all hosts are ready for a new data format. Displaying a big notification is a better option, yet in production installations where the upgrade process is controlled by puppet/chef/whatever those logs won't be seen. It is necessary to make it more clear in the documentation that data are not migrated automatically.

romcheg avatar Jun 17 '19 09:06 romcheg

How about adding a question on apt upgrade? For example some packages have default configs, which can overwrite your custom settings. On apt-upgrade, they ask you if you want to keep your configuration or use the new upstream config. But I think it is reasonable to modify things on apt upgrade.

bprfh avatar Jun 17 '19 12:06 bprfh

If I may suggest, if not running ralph migrate leaves the server inconsistent, then it is not matter of an option. it has to be executed. Rather I would say the question should be asked beforehand, not after. And always recommend users to do a backup of the machine.

rdarioc avatar Jun 18 '19 12:06 rdarioc

Is there even documentation of the need to run ralph migrate? I ask because I just searched on https://ralph-ng.readthedocs.io/en/stable/ for 'upgrade' and found nothing about upgrades at all.

kingmaiku avatar Oct 14 '20 19:10 kingmaiku