ralph icon indicating copy to clipboard operation
ralph copied to clipboard

Support Debian Buster and MariaDB

Open CaptainSifff opened this issue 6 years ago • 10 comments

Curerntly the debian scripts prevent a build on Debian Buster. Among the notable changes are:

  • Debian Buster ships mariadb instead of mysql, hence some package names have changed
  • Python-3.7 is the default.

CaptainSifff avatar Feb 07 '19 15:02 CaptainSifff

Coverage Status

Coverage increased (+0.07%) to 84.549% when pulling 1b8a5203f0864a54cff8284d07932ce1eaa44318 on CaptainSifff:ng into 398e4706ad7ccece0906a9ba489a260cb87ffa04 on allegro:ng.

coveralls avatar Feb 07 '19 15:02 coveralls

@CaptainSifff Ralph is not tested against python-3.7 and MariaDB and most likely the tests will fail. Could you please verify this?

romcheg avatar Feb 08 '19 03:02 romcheg

Sure, I can check. does ralphctl expose some kind of testsuite? I had to fiddle a bit with the package version in requirements.txt (rq >= 0.12 and django-rq >= 1.2.0) But so far, I found that I can populate the database with the demo data and play with that dataset through the browser without noticing any issues so far.

CaptainSifff avatar Feb 08 '19 08:02 CaptainSifff

I tested some of the ralphctl commands: ralphctl demodata: seems to work - database is populated and looks like I think it is expected. ralphctl sqlflush - lots of output, no error ralphctl ldap_sync - fails, currently not built with ldap(comes next) ralphctl push_graphs_to_statd - no output, no error ralphctl check - System check identified no issues (0 silenced). ralphctl compilemessages - no error ralphctl createcachetable - no error, no output ralphctl dbshell - Mariadb shell preset to the ralph_ng database ralphctl shell - Python3.7 shell ralphctl test - Creating test database for alias 'default'... Got an error creating the test database: (1044, "Access denied for user 'ralph_ng'@'localhost' to database 'test_ralph_ng'") Which is expected that In the spirit of the installation docs I only gave permission to acces the database ralph_ng ralphctl rqstats - Connection refused, somehow expected since I didn't set up redis

Anything else that you are interested in?

CaptainSifff avatar Feb 08 '19 14:02 CaptainSifff

I also got ldap and openldap sufficiently working for my needs by following the steps from the doc: https://ralph-ng.readthedocs.io/en/latest/installation/configuration/ I also needed the patch from #3080 for patching ldap.py and the documentation given in #3077 for patching prod.py.

CaptainSifff avatar Feb 11 '19 15:02 CaptainSifff

@CaptainSifff thank you for the research you have made. Before we start shipping the package for debian, we should enable automatic tests for 3.7 and mariadb. A spare pair of hands (you :) ) would be helpful for that atm. Let's discuss details in our Gitter channel.

romcheg avatar Feb 28 '19 10:02 romcheg

I also modified now the template as pointed out by @romcheg so that mariadb should be a possibility.

CaptainSifff avatar Mar 03 '19 09:03 CaptainSifff

@romcheg Do we wait for something here? is it RTM?

vi4m avatar Mar 11 '20 14:03 vi4m

@vi4m the changes do not allow to build the package for Buster within the existing build scripts, so we cannot merge this.

romcheg avatar Mar 11 '20 14:03 romcheg

Can somebody remind me what I would have to check...? The pipeline still goes through or did I miss a point?

CaptainSifff avatar Mar 11 '20 19:03 CaptainSifff