embedded-elasticsearch icon indicating copy to clipboard operation
embedded-elasticsearch copied to clipboard

Support ElasticSearch 7.0.0

Open yuriy-slobodchikov opened this issue 5 years ago • 14 comments

This is update request. Please, Support ElasticSearch 7.0.0

yuriy-slobodchikov avatar Apr 11 '19 10:04 yuriy-slobodchikov

This would be great!

Can you say something about how hard it is to add support for the new ES version, and what the expected timeline is?

nov1n avatar Apr 12 '19 08:04 nov1n

@nov1n Hello, sorry for not clear state in initial description. This is update request for Support ElasticSearch 7.0.0 I am using embedded-elasticsearch in projects and would like to use it with ElasticSearch 7.0.0

yuriy-slobodchikov avatar Apr 12 '19 13:04 yuriy-slobodchikov

@nov1n "Can you say something about how hard it is to add support for the new ES version, and what the expected timeline is?" I dont know) I just created issue to let know contributors that it would be nice to support ElasticSearch 7.0.0

yuriy-slobodchikov avatar Apr 12 '19 13:04 yuriy-slobodchikov

I have a WIP here: https://github.com/psk-ixolit/embedded-elasticsearch/commits/master

psk-ixolit avatar Apr 18 '19 15:04 psk-ixolit

@psk-ixolit I just sent a PR as well. How did you deal with the incompatible changes to indexing and templating APIs? I'm not very happy with my solution, but I couldn't see a better way.

danderson avatar Apr 18 '19 15:04 danderson

I didn't yet. I have a starting ES 7.0 version which was enough for my usecase. I tried porting the tests, bit didn't finish it.

However I quickly added a jitpack build to it: https://jitpack.io/#psk-ixolit/embedded-elasticsearch

The master snapshot works: https://jitpack.io/com/github/psk-ixolit/embedded-elasticsearch/master-embedded-elasticsearch-2.10.0-ge65deca-5/build.log

dependencies {
   implementation 'com.github.psk-ixolit:embedded-elasticsearch:master-SNAPSHOT'
}

psk-ixolit avatar Apr 25 '19 12:04 psk-ixolit

any chance of seeing this happen soon ?

bsilla avatar May 16 '19 20:05 bsilla

Have you started working on support for ES 7.0? Any progress?

sylwester-gk avatar May 17 '19 07:05 sylwester-gk

Thanks for your work. I am waiting for ES 7.x support as well.

rdpatil4 avatar May 17 '19 18:05 rdpatil4

I'm also interested in the ES7 support. Any progress so far?

gianvitom avatar Oct 10 '19 16:10 gianvitom

I ended up using elasticsearch-cluster-runner. Works great for my needs, and migration wasn't painful.

bsilla avatar Oct 10 '19 18:10 bsilla

It worked for me manually downloading from a 7.1.1 OSS URL and renaming the download to drop any name segments after the version number, then the starting worked for me. (To achieve this I had to create pl.allegro... namespaced classes to work around some encapsulation, but in the end I just needed to one class and create one new one) Didn't need any additional plugins etc., just needed a running instance. Thought about creating a PR, but from the looks of the Github repo I'd guess the maintainer has deserted this project (thanks for sharing this code anyways). If this repo / dependency is still alive I would be happy to contribute back

cbromberg avatar Feb 03 '20 13:02 cbromberg

We have migrated our integration tests to https://www.testcontainers.org/modules/elasticsearch/. It's quite straightforward to write a few lines long wrapper that will offer similar API as this library.

Thank you ALLEGRO for creating this library and keeping it up-to-date for a very long time. It has kept our integration tests running for several years. And now with testcontainers it's time to move on.

Best regards, Tomas

todvora avatar Apr 28 '20 05:04 todvora

We have migrated our integration tests to https://www.testcontainers.org/modules/elasticsearch/. It's quite straightforward to write a few lines long wrapper that will offer similar API as this library.

Thank you ALLEGRO for creating this library and keeping it up-to-date for a very long time. It has kept our integration tests running for several years. And now with testcontainers it's time to move on.

Best regards, Tomas

The same, we migrate to testcontainers

SiwyDym avatar Apr 30 '20 13:04 SiwyDym