Feature/use global version

[jwermuth]

trafficstars

Thanks for a nice plugin. This is the implementation of issue #340

It has code and tests and user documentation allowing user to do

    scmVersion {
        useGlobalVersion = true
    }

and

# ./gradlew currentVersion -Prelease.useGlobalVersion

I implemented this for a project where I need it. It would be nice with a release including it (if it passes acceptance, of course) soon.

Regards Jesper

[coveralls]

Coverage increased (+0.5%) to 57.913% when pulling 9aff1dad5ccd30f19a26db5635f5a67835cdae09 on jwermuth:feature/useGlobalVersion into b02d6bac834140ed3b4c7fa12ef08d913f4162ee on allegro:master.

[jwermuth]

@adamdubiel can I do anything to offload you, so this PR (regarding #340 ) can get merged

[km-at-aloteq-dev]

Hi guys!

I'm also voting for this feature. It is highly required for my projects as well.

Best regards, Konstanty

---

Cześć Państwu!

Oddaje też swój głos za tą funkcję! Bardzo potrzebuje ją w moich projektach!

Pozdrawiam, Konstanty

[jwermuth]

Merged the lastest changes on master ( #317 ) into feature/useGlobalVersion branch on jwermuth/axion-release-plugin. Tests are still green. @adamdubiel can I do something to get this PR merged ?

[bgalek]

hi @jwermuth, thanks for Your contribution and patience! I'll look at it and I hope we will add this feature to the next axion-release-plugin release ;)

[jwermuth]

@bgalek thanks for giving my PR some attention. I have noticed that the latest code on master breaks my PR. I will start looking at it now, and push when its fixed.

[cristianrgreco]

It is a shame to see this PR that was ready 2 years ago and maintained for almost 1 year has gone stale instead of being merged. This would have been very helpful for my case as well.

[grhawk]

Why is this not merged!? :( Let me know if I can help... but this would be an very appreciated feature!

[bgalek]

@grhawk sure, I'll help to merge it - but i need help - you could start with rebasing this branch

[grhawk]

@bgalek I tried, this is really just a single rebase, there is nothing to merge... if I have to do it, it means that I should create a pull request to @jwermuth to just move a pointer in git. I really think the best approach is that one of you does it... I think my "help" would only make things slower and messier...

[bgalek]

just fork his repo, rebase and push it as your own PR

[grhawk]

mmm I did a mistake... it actually a mess even just to merge the 2 branches... it looks like some major refactoring went on... I will have a look in the next days... but I really think this is going to be difficult!

[big-andy-coates]

I've a question on the validity of this feature... https://github.com/allegro/axion-release-plugin/issues/340#issuecomment-1423905164

[grhawk]

@bgalek hey, sorry I disappeared under tons of stuff to do... I may have time in the next couple of weeks of tackling the issue... just let me know if you are still interested in merging this... :)

[grhawk]

@bgalek I assume the "heart" is "yes"... but please, don't let me work on this if you are not interested in merging it :)

[bgalek]

I'll be happy to merge it, I should be able to check everything next week

[big-andy-coates]

I'll be happy to merge it, I should be able to check everything next week

Did you notice my question on the validity of this feature: https://github.com/allegro/axion-release-plugin/issues/340#issuecomment-1423905164

Happy to be overruled, but wanted to highlight.

[bgalek]

@big-andy-coates has a good point there