axion-release-plugin icon indicating copy to clipboard operation
axion-release-plugin copied to clipboard

SnapshotDependenciesChecker fails for multi module project

Open mazdack opened this issue 4 years ago • 7 comments

For example you have 2 modules: api and server. Server uses api module like this implementation(project(":api")) Then the snapshot check fails: > The project uses snapshot versions - can't release. Snapshots found

I think there should be possibility to ignore some dependencies.

mazdack avatar Mar 31 '20 08:03 mazdack

Same here. All project() dependencies are breaking release.

Kindrat avatar Apr 08 '20 13:04 Kindrat

@Kindrat is your change actually releasing SNAPSHOT dependencies? That would be cool, stuck on this one.

I have similar issue but instead of ignoring SNAPSHOTs I'd rather like to have possibility to release them to full version. It's because I'd like to run ./gradlew release on whole multiproject instead of on concrete modules in proper order.

dlesniakdev avatar Jun 25 '20 12:06 dlesniakdev

@dlesniakdev yeah, that was for snapshot release. All external deps are releases, while internal modules are snapshots.

Kindrat avatar Jun 26 '20 12:06 Kindrat

We have an internal plugin that we include Axion with and also encountered this issue when updating;

Downgrading Axion to 1.10.3 resolves it for us

> 1.10.3

→% gradle currentversion

> Task :currentVersion
Current Version:
Gradle Detected: 1.1.4
Axion Detected: 1.1.4
Internal Detected: 1.1.4

> Task :jar-sub:currentVersion
Current Version:
Gradle Detected: 1.1.5-SNAPSHOT
Axion Detected: 1.1.5-SNAPSHOT
Internal Detected: 1.1.5-SNAPSHOT

<= 1.10.3

→% gradle currentversion

> Task :currentVersion
Current Version:
Gradle Detected: 1.1.4
Axion Detected: 1.1.4
Internal Detected: 1.1.4

> Task :jar-sub:currentVersion
Current Version:
Gradle Detected: 1.1.4
Axion Detected: 1.1.4
Internal Detected: 1.1.4

It appears its most likely related to changes that occurred with; https://github.com/allegro/axion-release-plugin/commit/7202376bba5549a2ac75976f2bf4730638c02f25

But I'm not sure how we opt-out of this behavior and should have probably been opt-in instead of changing the existing default behavior

k3mist avatar Jul 23 '20 16:07 k3mist

Hello,

I am facing the same issue SnapshotDependenciesChecker fails for multi module project. did anyone able to resolve it ?

radusuma avatar Feb 11 '21 20:02 radusuma

@mazdack @radusuma @k3mist could you test @Kindrat's PR https://github.com/allegro/axion-release-plugin/pull/331/files?

bgalek avatar Oct 25 '21 06:10 bgalek

We could marge it in next release if it helps with your issues!

bgalek avatar Oct 25 '21 06:10 bgalek

I just ran into this, but only due to upgrading to gradle 7.6. On gradle 7.5.1 I did not have this problem.

Edit: Turns out my problems stemmed from having the plugin on each submodule when I really wanted it only on the root project.

gabrieljones avatar Nov 28 '22 15:11 gabrieljones

merged and released!

bgalek avatar Nov 28 '22 17:11 bgalek