axion-release-plugin icon indicating copy to clipboard operation
axion-release-plugin copied to clipboard

added regex to filter out tags which overlap in repo

Open Darkest opened this issue 7 years ago • 3 comments

This pull request fixes the following restriction: tag prefixes for each module do not overlap, i.e. !tagA.startsWith(tagB) for each permutation of all tag prefixes

Now tags are filtered by stronger regex, filtering out all tags that do not match the pattern <tagPrefix><tagSeparator>-

Darkest avatar Jun 11 '18 12:06 Darkest

Coverage Status

Coverage remained the same at 63.325% when pulling 517dc1d3c5735c3bbbd4b4fdd1034bf56ce4bbc6 on Darkest:master into 5c461cff052621a23180a60b71792bbbc17cabe5 on allegro:master.

coveralls avatar Jun 11 '18 13:06 coveralls

This looks really nice, but i'm worried about one thing: user can override tag serialization (using scmVersion.tag.serialize property) and chosen tag serialization might not match stronger regexp.. i'm not yet sure if this is a blocker, but to be on a safe side you might add a config flag to turn "strong regexp" on/off. It could be on by default in 1.10.0 . What do you think?

adamdubiel avatar Jun 13 '18 19:06 adamdubiel

I got your idea. Will look into it as i have time.

Darkest avatar Jun 17 '18 17:06 Darkest