axion-release-plugin icon indicating copy to clipboard operation
axion-release-plugin copied to clipboard

Only push the new release tag instead of all tags

Open cliffred opened this issue 7 years ago • 5 comments

Currently, the axion-release-plugin pushes all tags when creating a release, and will therefore potentially also push tags that were unintended. Wouldn't it be cleaner if only the newly created release tag is pushed, or is this a conscious decision?

I've implemented this in a branch https://github.com/cliffred/axion-release-plugin/tree/push-release-tag-only and it seems to work, but I have not tested it thoroughly. I justed wanted to know if you like the idea.

cliffred avatar Feb 21 '18 12:02 cliffred

This is a great suggestion! I will take a look at the code.

I added one comment directly in your PR, and i would like to see a test for it, but all in all i would be happy to merge it.

adamdubiel avatar Feb 23 '18 15:02 adamdubiel

I'll try to create a test and look at your comment some time this week.

cliffred avatar Feb 26 '18 10:02 cliffred

I've added a test, see https://github.com/cliffred/axion-release-plugin/commit/f7c6b4c28f4ddc8f2949984242c032b7043eee84

But I'm not sure how to handle the PushReleaseTask and HookContext as they also do pushing, and at that time you don't know the release tag.

cliffred avatar Mar 02 '18 12:03 cliffred

@cliffred how do You feel about creating PR to the main repo?:)

bgalek avatar Mar 27 '21 23:03 bgalek

@bgalek Last time I stumbled upon the problem of handling pushing in PushReleaseTask and HookContext. I can't remember the exact details, but I will look at again this weekend.

cliffred avatar Apr 02 '21 12:04 cliffred