axion-release-plugin icon indicating copy to clipboard operation
axion-release-plugin copied to clipboard

Snapshot version dependency version check limitations

Open jghandour opened this issue 8 years ago • 4 comments

The SnapshotDependenciesChecker does not work in some circumstances.

  1. It does not detect a snapshot buildscript in the 'buildscript' section. buildscript { dependencies { classpath 'pl.allegro.tech.build:axion-release-plugin:1.9.0-SNAPSHOT' } }

  2. It does not work when you are using the spring dependency management plugin to resolve the versions (https://github.com/spring-gradle-plugins/dependency-management-plugin).

I'm not sure on the proper solution, but it seems using 'it.buildscript.configurations' and 'resolvedConfiguration' will give you the required information.

A colleague has a potential fix for the second issue in this branch: https://github.com/hexsel/axion-release-plugin/commit/1bb508cd1b1cb2748c8785c94c53df613c030b07

jghandour avatar Nov 01 '17 01:11 jghandour

I can merge the potential fix, as long as you can test it with your corner-cases :) Sorry for ignoring this issue for so long, i just noticed that it is still open.

adamdubiel avatar Feb 28 '18 11:02 adamdubiel

I'm trying to figure out some of the inconsistencies with the SnapshotDependenciesChecker. Some of mine will be verified, but it seems like anything defined as constraints at the top level aren't verified either, similar to the dependency-management-plugin mentioned above I believe.

nerderma avatar Nov 12 '19 19:11 nerderma

@adamdubiel Tagging you just to call this out again. I know this thread is old, but felt it contained useful background over creating a new issue.

nerderma avatar Dec 19 '19 16:12 nerderma

I would also add that it does not work with Gradle rich versions like latest.release and latest.integration. The plugin (could) automatically lock the versions in such case. That would enforce fixed versions on release.

ghilainm avatar Dec 20 '19 11:12 ghilainm