holiday_exporter icon indicating copy to clipboard operation
holiday_exporter copied to clipboard

support for multiple sets of custom holidays

Open mapshen opened this issue 4 years ago • 2 comments

The use case is to accommodate the needs of different organizations, which follow different holiday schedules.

I would imagine the configs go like this:

custom_holidays:
  - name: test
    region: us
    organization: A
    schedule:
    - date: "2019-12-17"
      description: "Some day this year only"

Other than the mandatory schedule field, the others are free-form key-value pairs (containing at least 1 pair), which translate to the labels of the is_holiday metric. Perhaps we can make name mandatory as well.

@allangood Do you think this is can be something we add?

mapshen avatar Oct 13 '20 16:10 mapshen

Hi @mapshen,

first of all, thank you for you interest in this code and for your help! :)

Yes, this is totally possible. I didn't make any field other than the date mandatory, to make things simple/easy. I still don't know if making the name mandatory is really important. Could you help me to understand better your request to make it mandatory?

Regards.

allangood avatar Oct 13 '20 16:10 allangood

It doesn't have to be but there should be a key-value pair at least (in addition to schedule) so that we can tell different is_holiday metrics apart.

mapshen avatar Oct 13 '20 17:10 mapshen