dotenvy icon indicating copy to clipboard operation
dotenvy copied to clipboard
verified publisher icon allan2

Add option_dotenv! macro

Open mantmorre opened this issue 1 year ago • 2 comments

Closes #85

This is my first pull request on a public repository. Please let me know how I could do better to improve!

I am fairly new to Rust, so I am not 100% familiar with the conventions. Please suggest any changes you believe will help improve the usability, etc. of the feature.

Thank you.

mantmorre avatar Apr 18 '24 03:04 mantmorre

Hi Aiden, thank you for your PR. I have noticed your enthusiasm in the multitude of comments left in this repo over the last day ;)

Heads up: this issue will have to wait for #101 which will probably take a while.

allan2 avatar Apr 18 '24 22:04 allan2

Hello allan! I'm very excited to work with you and many others on this repository.

Why not merge this PR, then reconcile it with the decision made in the discussion for #101?

mantmorre avatar Apr 19 '24 02:04 mantmorre

Updated for v0.16 I have not tested

mantmorre avatar Sep 11 '24 21:09 mantmorre

I have no plans to accept this PR. I am looking to add more configuration to the compile-time macro. See #128

allan2 avatar Sep 11 '24 21:09 allan2

Understood. Thank you for the learning experience at least!

mantmorre avatar Sep 11 '24 21:09 mantmorre