app
app copied to clipboard
all-contributors
feat: commit conventions
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
π Inspect: https://vercel.com/all-contributors-app/app/8yb7x41wc
β
Preview: https://app-git-commit-conv.all-contributors-app.vercel.app
[Deployment for d84a210 failed]
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
@Berkmann18 if you want to test the deployment for this PR, you can update the webhook URL to https://app-git-commit-conv.all-contributors-app.vercel.app/api/github/webhooks at https://github.com/organizations/all-contributors/settings/apps/all-contributors-preview#integration_hook_attributes_active
@Berkmann18 did you have a chance to see if it works? Can you rebase your PR on the latest changes?
@gr2m Not since I last worked on this which wasn't a high priority thing.
@gr2m Not since I last worked on this which wasn't a high priority thing.
@Berkmann18 Can I help check this one?
The latest updates on your projects. Learn more about Vercel for Git βοΈ
| Name | Status | Preview | Updated |
|---|---|---|---|
| app | β Ready (Inspect) | Visit Preview | Sep 12, 2022 at 7:22PM (UTC) |
@tenshiAMD I've resolved the conflict. And yeah, you can help check that.
Codecov Report
Base: 99.21% // Head: 99.22% // Increases project coverage by +0.01% :tada:
Coverage data is based on head (
7da26e6) compared to base (98a3a02). Patch coverage: 100.00% of modified lines in pull request are covered.
:exclamation: Current head 7da26e6 differs from pull request most recent head 70fe001. Consider uploading reports for the commit 70fe001 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## master #343 +/- ##
==========================================
+ Coverage 99.21% 99.22% +0.01%
==========================================
Files 15 15
Lines 381 387 +6
Branches 46 47 +1
==========================================
+ Hits 378 384 +6
Misses 3 3
| Impacted Files | Coverage Ξ | |
|---|---|---|
| lib/add-contributor.js | 100.00% <100.00%> (ΓΈ) |
|
| lib/modules/config.js | 95.52% <100.00%> (+0.13%) |
:arrow_up: |
| lib/modules/repository.js | 100.00% <100.00%> (ΓΈ) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@Berkmann18 if you want to test the deployment for this PR, you can update the webhook URL to
https://app-git-commit-conv.all-contributors-app.vercel.app/api/github/webhooksat github.com/organizations/all-contributors/settings/apps/all-contributors-preview#integration_hook_attributes_active
@gr2m @Berkmann18 all looks good now. how can we test live?
@Berkmann18 @gr2m I think we should set the default to use angular since that's the currently being used right now
:tada: This PR is included in version 1.15.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@Berkmann18 @gr2m I think we should set the default to use
angularsince that's the currently being used right now
Not every repo use a commit convention and the setting was the users not just us.
Not every repo use a commit convention and the setting was the users not just us.
@Berkmann18 yes that's true however in the app the default is using angular. is CLI currently using none?
They both should have been the same, it must have been a mistake or a leftover from some corrections.