app icon indicating copy to clipboard operation
app copied to clipboard

Published 20 hours ago • verified publisher icon all-contributors

WIP fix: base off existing branch only if it exists and has an open pull request

Open hertzg opened this issue 3 years ago • 1 comments

Fixes #336

⚠️ WIP ⚠️

TODO:

  • [ ] Save nock response snapshots for new pull request checks in happy paths

hertzg avatar Jan 07 '21 17:01 hertzg

@hertzg is attempting to deploy a commit to the All Contributors Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jan 07 '21 17:01 vercel[bot]

Hey @tenshiAMD, unfortunately I don't have time to work on this pr now, but feel free to finish it if it's a priority right now or let me know and I can close this.

hertzg avatar Sep 07 '22 11:09 hertzg

@gr2m I think this is the current behavior now. See any differences? Please check. Thanks.

tenshiAMD avatar Sep 12 '22 19:09 tenshiAMD

@hertzg Hi. Looks like the other tests got broken. Any ideas? What else are we missing here?

tenshiAMD avatar Sep 12 '22 20:09 tenshiAMD

I'll try to have look this week but can't promise

gr2m avatar Sep 12 '22 23:09 gr2m

@tenshiAMD Are you sure they just broke?

There’s a TODO on top of the PR

TODO:

  • [ ] Save nock response snapshots for new pull request checks in happy paths

hertzg avatar Sep 13 '22 05:09 hertzg

@tenshiAMD Are you sure they just broke?

There’s a TODO on top of the PR

TODO:

  • [ ] Save nock response snapshots for new pull request checks in happy paths

@hertzg yes I already update the snapshots, you can review the recent checks in this PR

tenshiAMD avatar Sep 13 '22 07:09 tenshiAMD

Closing for now. Recreated to a new PR https://github.com/all-contributors/app/pull/415.

tenshiAMD avatar Sep 17 '22 11:09 tenshiAMD