Nicolas Cornu comments

Results 113 comments of


                                            Nicolas Cornu

Option to track usage/coverage of NMODL grammar rules from Bison specification

We should look at https://github.com/neuronsimulator/nrn/issues/1957 Some of those items are already covered.

Add a check for external definitions that are not thread safe

And so we use some of them. What should we do?

Add a check for external definitions that are not thread safe

I found this quite related: https://github.com/BlueBrain/nmodl/issues/249

Indexed node with expression contains `Name` and not `VarName`

We should remove `VarName` at then and use `Identifier` (base class of all type).

Indexed node with expression contains `Name` and not `VarName`

Related to #903

Code generation code cleanup for thread variables usage and derivimplicit

I always like to clean code, but what was the idea behind this ticket?

Compile time investigation of NMODL

I use a tool called `ts` that add the time in front of each line. After I use `make -j1`. The time is the time to print the line. >...

Compile time investigation of NMODL

I try to precompiled `ast.hpp`, it changes nothing

Compile time investigation of NMODL

Related to: https://github.com/BlueBrain/nmodl/issues/260

state_discontinuity functions not defined

From this mod file https://github.com/suny-downstate-medical-center/netpyne/blob/coreneuron/examples/coreneuron/m1/mod/my_exp2syn.mod#L82_L86 We can see: ``` NET_RECEIVE(weight (uS)) { state_discontinuity(A, A + weight*factor) state_discontinuity(B, B + weight*factor) } ``` and mod2c generate: ```c++ state_discontinuity(-1, &A, A +...