client-web icon indicating copy to clipboard operation
client-web copied to clipboard

Option to embed iframe in MD editor

Open SimoneZaza opened this issue 7 months ago • 1 comments

Description

As a user I want to be able to embed a video from youtube into my post. As a user with a new Space, seeing these cool Arcade click-throughs, I want it even more!

Acceptance criteria

Server:

  • [ ] Extend the Markdown scalar type to detect iframe usage, plus
  • [ ] check against list of approved domains (see below)

Client:

  • [ ] Add button to MD editor, next to the image button

  • import SmartScreenOutlinedIcon from '@mui/icons-material/SmartScreenOutlined'; image.png

  • label: Embed Video

  • [ ] Clicking on the button opens a small dialog in which the user can paste the iframe code

  • Title: Embed Video or other Media

  • Text: Copy the embed/iframe code below

  • Large input field

  • Buttons: Cancel; Insert

Approved domains:

  • Youtube
  • Vimeo,
  • Arcade
  • Issuu

Additional Context

Timebox to 5

The result should look something like this: image.png

I found this on the tiptap website, not sure it can be used since it's still in experimental phase: https://tiptap.dev/docs/examples/experiments/iframe

Areas that will be affected

To be added during the refinement

SimoneZaza avatar Jul 16 '24 12:07 SimoneZaza