client-web icon indicating copy to clipboard operation
client-web copied to clipboard

Refactor CalloutPage.tsx and displayLocation

Open ccanos opened this issue 11 months ago • 2 comments

Description

As an Alkemio dev I want a clean codebase and an easy to maintain application

Acceptance criteria

  • [ ] CalloutPage, useCallouts and CalloutDetailsContainer don't have repeated code
  • [ ] useCallouts.ts (:174) and CalloutPage.ts (:113) don't have a type casting
  • [ ] (maybe) TypedCallout and TypedCalloutDetails are built from a single place in useCallouts, that would make CalloutDetailsContainer also use it

Additional Context

During the fix of server/#3656 (https://github.com/alkem-io/client-web/pull/5686 and https://github.com/alkem-io/client-web/pull/5696) some repeated code has been detected and we have dealt with code that is not easy to maintain. CalloutPage is the page shown when a callout is loaded directly by direct link. Have in mind also the state saved when opening a whiteboard in a dialog: LocationStateCachedCallout

Screen shots / UX designs / data that are relevant.

Areas that will be affected

To be added during the refinement

ccanos avatar Mar 07 '24 15:03 ccanos